Add a GUI builder for the existing ReplaceBlocks field - #603
Open
yyty947 wants to merge 77 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR extends the existing ReplaceBlocks field with a structured JavaFX rule builder, diagnostics, non-mutating preview, contextual source filters, and release-safety hardening while preserving the advanced text workflow and legacy syntax.
Main additions:
regex(...),literal(...), andprops(...)source modes;tile(...),no_tile(...),y(...), andbiome(...)filters;Approximately 91k of the 104.5k added lines are generated block-state catalogue JSON from Mojang server reports.
AI-assisted development
This feature, including the ReplaceBlocks Builder and related safety, testing, and documentation work, was developed with substantial assistance from OpenAI Codex.
AI assistance was used for implementation, debugging, test generation, performance analysis, cross-platform investigation, documentation, and code review. I defined the requirements and compatibility/safety boundaries, reviewed the resulting changes, and performed the manual UI and copied-world validation described below.
Compatibility
This preserves the existing ReplaceBlocks text contract:
No automatic world-version detection or cross-version ID conversion is introduced.
Safety
Suggested review order
Because this is an end-to-end feature, I suggest reviewing it in this order:
The generated catalogue JSON can be reviewed separately from the handwritten code.
Validation
Final branch:
buildandshadowJarpassed on the final source tree;jpackageapp-image passed;--helpwith exit code 0;GitHub-hosted matrix on commit
41d6a127:jpackagepassed;The Windows workflow later reports HTTP 401 while downloading the restricted
Querz/build-toolsrelease in this fork. The Windows build and app-image package had already completed; this appears to require upstream repository credentials rather than a source change.Additional validation included:
A physical macOS UI interaction pass was not available; macOS Intel/ARM compilation, tests, and DMG packaging passed in GitHub Actions.
Documentation
Concise syntax, compatibility, and safety documentation is included in
docs/REPLACE_BLOCKS.md.If this feature is accepted, I would also be happy to adapt that documentation into the MCA Selector wiki according to the maintainer's preferred structure.
Out of scope